22/12/13 20:09, intrigeri wrote:
> Hi,
>
> please review feature/5588-no-autologin-consoles and merge it into
> devel, candidate for 0.23. Ticket = #5588.
>
> There's a branch in our main repo + another one (same name) with
> a snapshot version in the greeter repo, so the merge implies to
> release tails-greeter 0.7.23.
Code review passed without comment.
Everything seemed to work as intended during testing. (I had to build a
new t-g snapshot with master merged into it (just for testing purposes,
not uploaded or pushed) since the one in the APT suite is so old (based
on 0.23) that t-g 0.24 is pulled instead.)
Great work!
> Note that there's one potentially non-consensual in there:
[...]
> * Seriously, the intended users (debugging for developers or power-users) can
> as well `loadkeys' their preferred layout.
I agree. However, typing `sudo loadkeys ${keymap}` and perhaps in
particular the password, which have no visual feedback, may be pretty
awkward even for power users that are used to some particularly non-us
layouts. :) Short of a way to change the keymap without root privileges
I suppose we're stuck with this.
Given that two months have passed without objection, I think we have
consensus.
I want to merge this, but I'm tempted to delay it until some of the
other Tails Greeter merges are also in, to avoid some of the packaging
overhead. Therefore I also leave the ticket as is until I actually merge
it. Does this make sense?
Cheers!
