Re: [Tails-dev] #6538: Tails Installer tries to install to t…

Ok I'll have a look of it.

Also I attached a patch for "persistence: optimize window height" https://labs.riseup.net/code/issues/5458.

Cheers,

Andres
________________________________________
From: tails-dev-bounces@??? [tails-dev-bounces@???] on behalf of intrigeri [intrigeri@???]
Sent: 26 December 2013 22:37
To: The Tails public development discussion list
Subject: [Tails-dev] #6538: Tails Installer tries to install to too small       devices [Was: Installation USB-Stick]

intrigeri wrote (10 Sep 2013 10:17:30 GMT) :
> Andreas Meyer wrote (10 Sep 2013 09:53:02 GMT) :
>> I guess this is all because the stick is just 1 GB and not 2 GB.

> Yes, probably.

> After fiddling manually with GPT / MBR, I have sometimes seen this
> error too (due to some weirdness in how GPT legacy mode works, IIRC)
> even when doing "Clone & Install".

> Wiping out the first MB or so of the drive has always restored things
> to workable state for me.

Actually, while working on the automated test suite, I've hit this
issue in this scenario:

  Scenario: Installing Tails to a USB drive with an MBR partition table but no partitions
    Given a computer
    And I create a 2 GiB disk named "mbr"
    And I create a msdos label on disk "mbr"
    And the computer is set to boot from the Tails DVD
    [...]
    And I plug USB drive "mbr"
    And I "Clone & Install" Tails to USB drive "mbr"

So, it seems that Tails Installer does not correctly detect when the
destination device is too small to hold the system partition. The fact
that the destination device already has a MBR partition table might
matter, or not.

Reported as #6538, added implementation hints, marked as "easy":

https://labs.riseup.net/code/issues/6538

Any taker? (This looks like good stuff for e.g. Andres or WinterFairy,
I guess.)

Cheers!
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
_______________________________________________
tails-dev mailing list
tails-dev@???
https://mailman.boum.org/listinfo/tails-dev
From 6619a3f225828da50f8da31783372536846b1c86 Mon Sep 17 00:00:00 2001
From: kurono <andres.gomez@???>
Date: Sat, 4 Jan 2014 19:16:58 +0100
Subject: [PATCH] persistence: optimize window height

---
 lib/Tails/Persistence/Setup.pm |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/Tails/Persistence/Setup.pm b/lib/Tails/Persistence/Setup.pm
index 401dbe3..2641889 100644
--- a/lib/Tails/Persistence/Setup.pm
+++ b/lib/Tails/Persistence/Setup.pm
@@ -635,6 +635,7 @@ sub empty_main_window {

 sub run_current_step {
     my $self = shift;
+    my ($width, $height) = $self->main_window->get_size();

     $self->debug("Running step " . $self->current_step->name);

@@ -645,6 +646,10 @@ sub run_current_step {
     $self->main_window->show_all;
     $self->current_step->working(0);
     $self->main_window->set_visible(TRUE);
+
+    if($self->current_step->name eq 'configure') {
+        $self->main_window->resize($width, $self->main_window->get_screen()->get_height());
+    }
 }

sub goto_next_step {
--
1.7.9.5