[Tails-dev] Please review'n'merge feature/5588-no-autologin-…

Delete this message

Reply to this message
Autore: intrigeri
Data:  
To: tails-dev
Nuovi argomenti: Re: [Tails-dev] Please review'n'merge feature/5588-no-autologin-consoles, Re: [Tails-dev] Please review'n'merge feature/5588-no-autologin-consoles
Oggetto: [Tails-dev] Please review'n'merge feature/5588-no-autologin-consoles
Hi,

please review feature/5588-no-autologin-consoles and merge it into
devel, candidate for 0.23. Ticket = #5588.

There's a branch in our main repo + another one (same name) with
a snapshot version in the greeter repo, so the merge implies to
release tails-greeter 0.7.23.

Assigned to the 0.23 RM for review, but I bet anonym would not mind if
someone beat him to it.

Note that there's one potentially non-consensual in there:

commit 1337104f82a6c6aa03eb7f5ed995761ce07fdf92
Author: Tails developers <amnesia@???>
Date: Sun Dec 22 18:03:16 2013 +0000

    Drop console localization profile.d snippet.


    We don't autologin the consoles anymore, so we don't need something this
    complicated anymore. I could not bother myself to adapt and simplify it as:


     * It's broken on feature/wheezy (#5583) and I see little use in spending any
       time on this feature at this point.
     * Seriously, the intended users (debugging for developers or power-users) can
       as well `loadkeys' their preferred layout.
     * The removed snippet required tails-greeter to give the "amnesia" user the
       right to run "setupcon" as root.


Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc