anonym wrote (27 Nov 2013 14:00:55 GMT) :
> I think I have simpler and cleaner suggestion: we keep tails-spoof-mac
> as it is, so it still has `set -e` and no fail-safe; instead we put the
> fail-safe in tails-unblock-network, right after udev has settled (=> we
> know the hooks have finished), i.e. something like:
> if mac_spoof_is_enabled; then
> for nic in get_all_ethernet_nics; then
> if ! mac_is_spoofed; then
> # Panic mode: unload the NIC's module, etc.
> # Show an appropriate warning in a notification to the user
> fi
> done
> fi
> There are even more advantages if we move the NM starting code into the
> same script as well (as I suggested in another post): we may want to
> *not* start NM if we failed to unload a failing NIC's module in "panic
> mode". That'd also more explicitly enforce the pre-condition for
> actually taking the final steps to enable the network, which is good.
At first glance, this looks good to me. Do we agree this should be
part of the first iteration?
Cheers!
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
