Re: [Tails-dev] Please review whisperback:a4dfd008

Delete this message

Reply to this message
Autor: intrigeri
Data:  
A: The Tails public development discussion list
Assumpte: Re: [Tails-dev] Please review whisperback:a4dfd008
Alan wrote (25 Nov 2013 13:25:23 GMT) :
> On Mon, 25 Nov 2013 10:24:49 +0100
> intrigeri <intrigeri@???> wrote:


>> I find it slightly disturbing to see regexp changes without any single
>> example (be it in the commit message, some design doc, or executable
>> specification^W^Wtest suite) of what strings are newly supposed to
>> match or to not match anymore thanks to the change.
>>
> See the bug report:


I'm hereby ACK'ing the patch too, even if I'm not convinced by this
reply: IMHO reading a commit should be enough to understand the
changes it carries, without having to go read a bug report on an
unspecified online ticket tracker (WhisperBack is not
Tails -specific).

Anyway: great, thanks! :)

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc