On Mon, 25 Nov 2013 10:24:49 +0100
intrigeri <intrigeri@???> wrote:
> Alan wrote (24 Nov 2013 12:51:10 GMT) :
> > # IPs
> > - log_string = re.sub(r'\<([\d]{1,3}\.){3}[\d]{1,3}\>',
> > + log_string = re.sub(r'([\d]{1,3}\.){3}[\d]{1,3}',
> > r'[IP REMOVED]',
> > log_string)
> > # MAC addresses
> > - log_string = re.sub(r'\<([0-9a-fA-F]{2}:){5,}[0-9a-fA-F]{2}\>',
> > + log_string = re.sub(r'([0-9a-fA-F]{2}:){5,}[0-9a-fA-F]{2}',
>
> I find it slightly disturbing to see regexp changes without any single
> example (be it in the commit message, some design doc, or executable
> specification^W^Wtest suite) of what strings are newly supposed to
> match or to not match anymore thanks to the change.
>
See the bug report:
[ 000.000000] wlan0: authenticate with 00:xx:xx:xx:xx:xx
[ 000.000000] wlan0: send auth to 00:xx:xx:xx:xx:xx (try 1/3)
[ 000.000000] wlan0: authenticated
[ 000.000000] wlan0: associate with 00:xx:xx:xx:xx:xx (try 1/3)
[ 000.000000] wlan0: RX AssocResp from 00:xx:xx:xx:xx:xx (capab=0x411
status=0 aid=2)
Cheers
