Re: [Tails-dev] Fix: persistence: clearer warning at delete …

Delete this message

Reply to this message
Autore: Andres Gomez Ramirez
Data:  
To: The Tails public development discussion list
Oggetto: Re: [Tails-dev] Fix: persistence: clearer warning at delete step
>I've quickly tried it, and it works fine *but* the placement of the
>icon (centered, alone on top of the window) looks quite weird to me.


>Andres, would you please have a look at what the GNOME HIG says (if
>you like formal specs), or more easily, just copy what
>`zenity --warning' does (it's likely that it just applies the specs)?


Oh, you are right, I have fixed it according to GNOME HIG :)

> Oh, BTW: if you want more privs on Redmine, so that e.g. you could
> have marked the relevant ticket as ready for QA, and assign it to the
> current RM (me), just tell me what's your login there.


ok great, my user is kurono.

Cheers,

Andres

From 9b061467b7485187639cc62f2a926eb368c613d8 Mon Sep 17 00:00:00 2001
From: kurono <andres.gomez@???>
Date: Sun, 10 Nov 2013 21:00:45 +0100
Subject: [PATCH] persistence: clearer warning at delete step

---
 lib/Tails/Persistence/Step/Delete.pm |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)


diff --git a/lib/Tails/Persistence/Step/Delete.pm b/lib/Tails/Persistence/Step/Delete.pm
index 1a7cfd5..a3cee87 100644
--- a/lib/Tails/Persistence/Step/Delete.pm
+++ b/lib/Tails/Persistence/Step/Delete.pm
@@ -58,9 +58,14 @@ sub _build_main_box {
     my $self = shift;


     my $box = Gtk2::VBox->new();
+    my $hbox = Gtk2::HBox->new();
+    my $image = Gtk2::Image->new_from_stock("gtk-dialog-warning", "GTK_ICON_SIZE_DIALOG");
     $box->set_spacing(6);
+  
     $box->pack_start($self->title, FALSE, FALSE, 0);
-    $box->pack_start($self->subtitle, FALSE, FALSE, 0);
+    $hbox->pack_start($image, FALSE, FALSE, 0);
+    $hbox->pack_start($self->subtitle, FALSE, FALSE, 0);
+    $box->pack_start($hbox, FALSE, FALSE, 0);
     $box->pack_start($self->description, FALSE, FALSE, 0);


     $box->pack_start($self->status_area, FALSE, FALSE, 0);
-- 
1.7.9.5