Hi,
Alan wrote (08 Nov 2013 22:33:59 GMT) :
> On Thu, 17 Oct 2013 14:18:36 +0000 Alan <alan@???> wrote:
>> On Sat, 12 Oct 2013 09:36:52 +0200 intrigeri <intrigeri@???>
>> > Alan wrote (11 Oct 2013 17:52:19 GMT) :
>> > >> Just curious: any specific reason that I've missed to display the
>> > >> device size in the confirmation dialog on initial install, but
>> > >> not at upgrade time?
>> > >>
>> > > No.
>> >
>> > Do you intend to fix this (say, in time for 0.22), or should I?
>> >
>> I'll do it in time for 0.22.
>>
> Actually, there was a reason: at the time the dialog is shown, the
> installer switched (`switch_drive_to_system_partition`) its device from
> the disk (/dev/sdb) to the partition (/dev/sdb1) with the method
> `switch_drive_to_system_partition` and `drive['size']` contains the
> size of the partition, which doesn't contain relevant information.
> Fixed, but it required quite some code.
Great! (I was a bit scared by your "quite some code" remark, but in
the end "11 insertions, 4 deletions" looks minimal enough to me :)
>> > >> > +def _format_bytes(value):
>> > >> > + return '%0.1f GB' % (value / 10.0**9)
> [...]
> Done
Thank you.
>> > >> However, the No/Yes buttons ordering seems unusual to me. I
>> > >> didn't dare patching it, as I thought you might have followed
>> > >> the GNOME HIG or something, and I may be missing something. Any
>> > >> reason to order it this way?
>> > >>
>> > > No. I'm used to GTK+, which chooses the right order automatically.
>> > > Qt might not do that.
>> >
>> > Do you intend to fix this (say, in time for 0.22), or should I?
>> >
>> I'll too.
>>
> I just tested and got the same button ordering than (GTK) `zenity
> --question`, so I belive there is no problem to be solved.
Fair enough.
> Everything is in liveusb's feature/ui_improvement_followups branch.
Reviewed (untested), looks good.
> Expect a tails branch including it soon.
Great!
As a side process note, I'm not going to play the "let's pile up
multiple concurrent unmerged branches for software X before we merge
any of them" game again, it was too painful for 0.21. So, I'll wait
that:
1. feature/bigger-system-partition is reviewed and merged first
2. your branch merges feature/bigger-system-partition.
So, please, someone, review'n'merge feature/bigger-system-partition.
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
