Hi,
Kevin C. Krinke wrote (05 Nov 2013 17:45:51 GMT) :
> Just tested on Tails 0.22 (feature_wheezy-0.22-20131105T1143Z-30e8c3c).
> Note that there are two packages in addition to python-tz that are
> required. To install Tails Clock on 0.22, perform the following:
JFTR, 0.22 won't be based on Wheezy: these images have 0.22 in their
name only to indicated that the feature/wheezy branch is currently
based on the code that will be called 0.22 in December. The nightly
builds based on the devel branch are much closer to what
0.22 will be, so better not call "0.22" images built from
feature/wheezy.
So, I've tested this in a Tails/Wheezy image, and it works fine for
me. Congrats!
Various nitpicking follows:
* .config/tailsclock/settings reads:
# DO NOT EDIT - This file is overwritten automatically. #
May I ask why? Isn't manual configuration supported?
When / why would manual configuration be overwritten?
* .config/tailsclock/timezone could use a newline at the end of the
file.
* "key: value" would look better to me than "key:value", and be closer
to YAML iirc.
* When the locale doesn't support AM/PM, why not simply hide the
config option in the prefs dialog, instead of locking it?
That may be only me, but I generally feel weird when I'm shown some
piece of UI that I can't interact with.
* Is it on purpose that a logfile is always created? I understand it's
useful at development time, but we won't want to ship with this in
production, will we? (Printing to STDERR would seem just fine to me,
so that logs land into ~/.xsession-errors, just like every other
similar message from a desktop software.)
* Please use dh-autoreconf in the Debian packaging.
* Please Depend: ${python:Depends}
* Please uncomment and update Vcs-Git and Vcs-Browser.
* Replace GPL-3.0+ with GPL-3+ in debian/copyright.
* Please upgrade to compat level 9 (debhelper 9 is in
squeeze-backports, so no need to use an older compat version).
* Please reformat debian/* with "cme fix dpkg" (needed tools are in
the libconfig-model-dpkg-perl package).
* s/Gnome/GNOME/ in the package description.
* Please fix the package description so that it doesn't lie about the
available options, and the supported version of GNOME (the rest of
the packaging is GNOME3-specific)
* No need to have separated "debian/*" and "*" sections in
debian/copyright, since the copyright holder and license are
the same. "*" will be enough :)
* Why ship a NEWS file? It seems obsolete.
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
