Re: [Tails-dev] Timing of the move to FF24

Nachricht löschen

Nachricht beantworten
Autor: intrigeri
Datum:  
To: Mike Perry
CC: tails-dev
Betreff: Re: [Tails-dev] Timing of the move to FF24
Hi Mike,

Mike Perry wrote (25 Sep 2013 02:37:38 GMT) :
> intrigeri:
>> 1. When do you expect to have published preliminary Torbrowser
>>    patches, rebased on FF24?


> Right now:
> https://gitweb.torproject.org/user/mikeperry/tor-browser.git/shortlog/refs/heads/torbrowser-firefox24.0


Thanks!

It fails to build for me, apparently due to:

  +      if (!spec.IsEmpty())
  +        msg.AppendASCII(spec.get());
  +      else:
  +        msg.AppendASCII(NS_LITERAL_STRING("Unknown URI!"));


... in fixup-Isolate-the-Image-Cache-per-url-bar-domain.patch.

That triggers:

  /tmp/buildd/iceweasel-24.0/image/src/imgLoader.cpp: In member function 'nsAutoCString imgLoader::GetCacheKey(nsIURI*, nsIURI*)':
  /tmp/buildd/iceweasel-24.0/image/src/imgLoader.cpp:1866:11: error: expected primary-expression before ':' token
         else:
           ^
  /tmp/buildd/iceweasel-24.0/image/src/imgLoader.cpp:1866:11: error: expected ';' before ':' token


I could presumably easily fix it locally, but it's way easier (patches
management -wise) if I can just pile up another fixup commit from you
on top of that one.

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc