Re: [Tails-dev] first patch attempt

Nachricht löschen

Nachricht beantworten
Autor: intrigeri
Datum:  
To: The Tails public development discussion list
Betreff: Re: [Tails-dev] first patch attempt
Hi,

Sina S wrote (26 Sep 2013 06:18:05 GMT) :
> Here is my first patch attempt, submitted by email as suggested by the
> website.


Thanks for this patch, and thanks a lot for caring about our preferred
way to receive and review patches. This is much appreciated.

> Feedback appreciated.


Here we go.

> +                if not src.lower().endswith('.iso'): shutil.copy(src, dst)


Assuming you've tested this and it works fine, the only comment I have
is that we might want to output a debug message (print >> sys.stderr)
such as:

Skipping FILENAME.iso...

If you think it's overkill, I probably wouldn't disagree.

Waiting for your confirmation that it was tested, and then I'm happy
to test and merge this patch :)

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc