Hi,
bertagaz@??? wrote (02 Sep 2013 10:59:48 GMT) :
> Branch: feature/More_uniq_built_iso_name_in_jenkins
> Ticket: #6248 (https://labs.riseup.net/code/issues/6248)
> 64f39f1 Use more unique iso name when building from jenkins.
> This commit introduces more unique iso name when building in jenkins so
> that we will be able to keep several isos per day in our CI environment.
Yeah :)
> +# * if jenkins build from a branch: tails-$ARCH-$BRANCH-$VERSION-$COMMIT-$TIME.iso
s/jenkins/Jenkins/
s/build/builds/ for consistency with the above lines.
> + if [ ! -z "$JENKINS_URL" ]; then
`! -z' can simply be called `-n'.
> + BUILD_BASENAME="tails-${LB_ARCHITECTURE}-${CLEAN_GIT_BRANCH}-${AMNESIA_VERSION}-${GIT_SHORT_ID}-${AMNESIA_NOW}"
I'd rather see the time/date ($AMNESIA_NOW) inserted *before* the
commit ID, so that lexical sorting is still equivalent (among builds
from a given branch * version) to time-based sorting.
> +AMNESIA_NOW="`TZ=UTC date '+%Y%m%dT%H%MZ'`"
`date --utc' looks more robust to me, but it surely can be debatted.
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
