Re: [Tails-dev] Please review'n'merge doc/update-persistence…

Delete this message

Reply to this message
Author: sajolida
Date:  
To: The Tails public development discussion list
Subject: Re: [Tails-dev] Please review'n'merge doc/update-persistence-path
>> On 13/08/13 18:39, Vigdis wrote:
>>> Hi,
>>>
>>> Hi, the path given here
>>> https://tails.boum.org/doc/first_steps/persistence/configure/#index13h2
>>> (/lib/live/mount/persistence/XXX_unlocked/live-additional-software.conf)
>>> is incorrect.
>>>
>>> I fixed it in branch doc/update-persistence-path.
>>>
>>> (It's my first review'n'merge, I've looked what informations people
>>> usually provide, but if I still miss something, please tell me.)
>>
>> Thanks for the patch.
>>
>> I think you should also replace the other occurrence of the same path
>> in the "Dotfiles" section of
>> doc/first_steps/persistence/configure.mdwn.
>
> Sure, I didn't see it. It's fixed.
>
>> I would also have a look at the .po files to see if I can unfuzz some
>> strings that would not contain language dependent strings.
>>
> Ok, I changed the paths in the .po files, I thought it would
> automagically done by ikiwiki's script build-wiki.


I had another look and was about to merge.
But then I saw that your commits were attributed to Vigdis.

Maybe that was not on purpose since we usually use a common identity for
that. See https://tails.boum.org/contribute/git/#index3h2.

I don't mind either option but I wanted an acknowledgment from your side
first.