29/07/13 20:11, intrigeri wrote:
> Hi,
>
> while working on this piece of software for unrelated matters, I've
> been hit by various minor bugs and usability issues, that I fixed
> (a434eda..d8c34c8) and pushed to the liveusb-creator master branch.
>
> anonym, when you prepare liveusb-creator 3.11.6-14 for RC1, may you
> please have a look at these changes? I know you may not be familiar
> with the codebase, but you'll see they are all tiny and relatively
> minor. I wouldn't mind if you run the relevant part of the automated
> test suite at this time too, just to catch any regression that my
> manual testing may have missed.
Reviewed and part of t-p-s 0.33, and hence Tails 0.20~rc1. While testing
Tails 0.20~rc1, the automated test suite was all green, so it looks good.
> Until now, we have not always done proper review'n'merge for all of
> our bundled custom packages, and changes have often been silently
> integrated at freeze time when the RM builds a new package with
> updated translations (seriously!).
>
> I'm not sure how we should handle that in the general case (and am
> more and more tempted to put all that stuff into Git submodules of our
> main repo),
Submodules sounds like a good idea, but is it really there the problem
is? Or perhaps it will help reminding us to use the review'n'merge since
those code bases are moved into one we're used to review'n'merge for
every change.
> but what I propose we do this time is: let's include these
> changes; then, if any regression is found while testing RC1, let's
> just revert to the previous version of the package. Worst case, we
> miss a bunch of translation updates. Best case, we get the bugfixes in
> + the l10n updates. Fair enough?
This is what was done.
Cheers!
