[Tails-dev] Please review a bunch of minor USB installer bug…

Delete this message

Reply to this message
Autor: intrigeri
Data:  
Dla: tails-dev
Temat: [Tails-dev] Please review a bunch of minor USB installer bugfixes/improvements
Hi,

while working on this piece of software for unrelated matters, I've
been hit by various minor bugs and usability issues, that I fixed
(a434eda..d8c34c8) and pushed to the liveusb-creator master branch.

anonym, when you prepare liveusb-creator 3.11.6-14 for RC1, may you
please have a look at these changes? I know you may not be familiar
with the codebase, but you'll see they are all tiny and relatively
minor. I wouldn't mind if you run the relevant part of the automated
test suite at this time too, just to catch any regression that my
manual testing may have missed.

Until now, we have not always done proper review'n'merge for all of
our bundled custom packages, and changes have often been silently
integrated at freeze time when the RM builds a new package with
updated translations (seriously!).

I'm not sure how we should handle that in the general case (and am
more and more tempted to put all that stuff into Git submodules of our
main repo), but what I propose we do this time is: let's include these
changes; then, if any regression is found while testing RC1, let's
just revert to the previous version of the package. Worst case, we
miss a bunch of translation updates. Best case, we get the bugfixes in
+ the l10n updates. Fair enough?

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc