Hi,
I know I'm late... but hara are some comments
On Sat, 13 Apr 2013 03:08:30 +0200 jvoisin <julien.voisin@???>
wrote:
> On 06/04/2013 10:23, intrigeri wrote:
> > Hi,
> >
> > jvoisin wrote (05 Apr 2013 21:04:37 GMT) :
> >> The MAT is now ported to Gtk3.
> >
> > Awesome! Congrats for all this good work :)
Congrats too
> >> +++ b/MAT/mutagenpowered.py
> >> [...]
> >> class MutagenStripper(parser.GenericParser):
> >
> > Just curious: hasn't Python any stricter best practices or
> > conventions wrt. how to name files that contain classes,
> > accordingly to these classes' name?
> I don't think so, but this is a good idea: renamed.
The name os the file is the name of the (sub)-module. In python one is
not supposed to make one file for each class.
> >> + ( 'share/nautilus-python/extensions',
> >> ['nautilus/nautilus-mat.py'] ),
> >
> > ... in the commit that adds Gtk3 support, while the Nautilus
> > extension is not in this Git tree. Mistake?
> Yes :/
> But the good news is that the nautilus extension is getting closer
> thanks to the Gtk3 port !
Is it included now? If no, may I help to make it happen?
> > But I get a warning in the GUI:
> >
> > $ ./mat-gui:588: UnicodeWarning: Unicode unequal comparison
> > failed to convert both arguments to Unicode - interpreting them as
> > being unequal if self.force or self.liststore[line][4] !=
> > _('Clean'):
> >
> > (running with French locales.)
> Weird, but I think that I designed something wrong.
> I don't think that I should compare translated strings,
> but constants instead. Maybe an associative array ?
> Anyway, it's added to the TODO-list.
Yo might want to add an hidden column containing arbitrary keys in your
liststore.
Cheers,
