Re: [Tails-dev] Please review and merge feature/about_tails

Nachricht löschen

Nachricht beantworten
Autor: Alan
Datum:  
To: tails-dev
Betreff: Re: [Tails-dev] Please review and merge feature/about_tails
Hi,

On Mon, 29 Apr 2013 19:55:36 +0200 intrigeri <intrigeri@???> wrote:
> Hi,
>
> > tails_version = subprocess.Popen(["tails-version"],
> > stdout=subprocess.PIPE).communicate()[0]
>
> I guess this is probably not a blocker, but does this throw an
> exception if `tails-version' fails for some reason, or does it fail
> and goes on more or less silently?
>

It failed and didn't went on. This is now fixed.

> Otherwise, looks good to me, congrats! I'm happy to test and merge
> once the history is cleaned up. Retagging the ticket accordingly.
>

Done. I did the merge in experimental an ugly way because of the
rebase (the branch is merged twice), please confirm wether I can push
like that.

Cheers