[Tails-dev] Please review bugfix/preserve_pot_charset [was: …

Poista viesti

Vastaa
Lähettäjä: sajolida
Päiväys:  
Vastaanottaja: The Tails public development discussion list
Vanhat otsikot: [Tails-dev] refresh-translations bug?
Aihe: [Tails-dev] Please review bugfix/preserve_pot_charset [was: Re: refresh-translations bug?]
On 21/04/13 01:51, Alan wrote:
> Hi,
>
> When finalizing feature/about_tails, I encountered a wired issue with
> PO files. Python's gettext crashes with a LookupError while reading
> encoding of the PO file header, which is... "CHARSET". This is obviously
> a wrong charset, but it's the one created by refresh-translations for
> newly created PO files:
>
>     "Content-Type: text/plain; charset=CHARSET\n"

>
> I currently workaroud that in my python scripts, but I'm afraid that
> the actual problem is in refresh-tranlsation. What do you think?


I agree. The script refresh-translations runs xgettext to generate new
POT files but it doesn't take into account the previous POT files, and
for example the charset that could have been defined in it.

Can you review and test the branch bugfix/preserve_pot_charset?