[Tails-dev] Please review & merge bugfix/udisks-do-not-make-…

Delete this message

Reply to this message
Autor: intrigeri
Data:  
A: tails-dev
Assumpte: [Tails-dev] Please review & merge bugfix/udisks-do-not-make-Tails-USB-unbootable
Hi,

Ticket: todo/palimpsest:_do_not_make_Tails_USB_unbootable
(updated and tagged todo/qa locally, can't push right now as the
live website is locked / being rebuilt).

Merged into experimental, candidate for 0.17.2 and 0.18
=> please review & merge into stable and devel.

Note that this changeset is needed by bugfix/writable_boot_media.

Due to a bug in parted, udisks users (GNOME Disk Utility,
tails-persistence-setup...) reset the system partition's attributes
when manipulating the partition table, e.g. when creating or deleting
a second partition.

We've been working around this in t-p-s with sgdisk calls, that are
now proven to be problematic as highlighted by anonym in his email
about boot medium permissions.

So, I propose we:

  * ship a parted package that has the patch backported from Wheezy to
    fix this bug at its roots
  * remove the sgdisk-based workaround in t-p-s
  * drop the obsolete dependency from liveusb-creator on
    python-parted, to avoid having to backport that one too (see
    Debian changelog for parted 2.3-12 for details)


All this was implemented in
bugfix/udisks-do-not-make-Tails-USB-unbootable. It works for me:

  * I still can install Tails on USB, boot from USB, setup
    persistence, reboot, delete persistent volume, reboot. One can
    check with sgdisk that the bootable flag is still here.
  * I now can install Tails on USB, boot from USB, create a partition
    with GNOME Disk Utility, reboot.


Note that even with the parted bugfix in place, only the bootable flag
is preserved, not the 3 non-critical other ones we set, but I consider
they're merely bonus, so I'm ignoring this for now (and actually,
I doubt we can ever do better without patching parted, which does not
seem worth it, so I'm not even filing a ticket about it).

Most of the changes are in the APT repository, t-p-s Git repo and
liveusb-creator repo, so reviewers should inspect these in addition to
the minor commit in our main Git repo.

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc