hi,
Alan wrote (13 Mar 2013 18:40:36 GMT) :
> Please review and merge the branch `feature/about_tails`.
Great. I see a few things that should be fixed, see bellow.
I think all translations should be preserved in the desktop file,
not only those for a half dozen half-randomly chosen languages.
> -Categories=GNOME;GTK;Core;Utility;
> +Categories=GNOME;GTK;Utility;
I'd rather not see changes made without a clear reason.
> +about_dialog.set_title=(_("À propos de Tails"))
This looks wrong to me.
> +about_dialog.set_copyright("Tails Developpers")
s/Delevoppers/developers/ for consistency reasons + fixing the typo.
I'll be happy to review (and test, this time) a fixed branch :)
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
