Re: [Tails-dev] Please review and merge feature/live-boot-3.…

Delete this message

Reply to this message
Autor: intrigeri
Data:  
Dla: The Tails public development discussion list
Temat: Re: [Tails-dev] Please review and merge feature/live-boot-3.x
hi,

Alan wrote (09 Feb 2013 11:08:00 GMT) :
> The following commit seems me buggy: commit
> message doesn't fit commit content


>     commit 9c96cb22904868771257f653936e0d7fac84f167
>     Author: Tails developers <amnesia@???>
>     Date:   Wed Nov 28 16:49:45 2012 +0100


>         Add compatibility symlink from /live/image
>         to /lib/live/mount/medium. 
>         Recent live-boot mounts the read-only live image in there..


>     diff --git a/config/chroot_local-includes/lib/live/image
>     b/config/chroot_local-includes/lib/live/image new file mode
>         120000 index 0000000..4201661
>     --- /dev/null
>     +++ b/config/chroot_local-includes/lib/live/image
>     @@ -0,0 +1 @@
>     +/live/mount/medium
>     \ No newline at end of file


I agree the commit message is unclear, but it's technically correct
since we also have a /live -> /lib/live symlink.

Note that there's a roadmap on the ticket to progressively make these
compat symlinks go away in 0.19.

> I didn't found a commit fixing this issue. Otherwise commit diff seems
> me OK.


Unfortunately, we can't fix the commit message with another commit.

> So it seems me OK, but please fix or explain the buggy commit before I
> merge the branch.


Do you feel it's necessary to rewrite this branch history to clarify
the commit message a bit? I don't, but I don't mind doing it if you
think it's needed.

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc