Author: Alan Date: To: tails-dev Subject: Re: [Tails-dev] Please review & merge
bugfix/fix_default_iceweasel_spelling_language
Hi,
On Wed, 06 Feb 2013 10:55:21 +0100
intrigeri <intrigeri@???> wrote: > Hi,
>
> Alan wrote (05 Feb 2013 17:39:11 GMT) :
> > Works for:
>
> > - english
> > - spanish
> > - french
> > - portugese
>
> > No language is selected for:
>
> > - deutsch
> > - italian
> > - tien viet
> > - russian
>
> Nice catches, thanks for testing.
>
> > I didn't test with arabic, farsi ans cheenese.
>
> > Apart from that, the commits seems me nice and I would be happy to
> > merge this branch.
>
> I'm happy to go on working on this later on, to improve stuff for the
> languages that still have issues, so please don't mark the ticket as
> pending after merging, and please add your testing results to
> the ticket.
> Added testing results and marked as todo/code.
> However, do you seriously think the fact some languages end up with no
> dictionary selected should prevent us from fixing the bug this branch
> targets? Given this behavior is no regression (things have never been
> better than that in any previous version of Tails) and is still an
> improvement over Tails 0.16 (that is, it actually fixes a bug),
> I certainly don't think we should block on this.
> This branch is aimed at fixing *one* specific bug, that's all :)
>
> Cheers,
