[Tails-dev] Please review (and merge?) feature/better_power_…

Delete this message

Reply to this message
Autor: anonym
Data:  
Dla: The T(A)ILS public development discussion list
Temat: [Tails-dev] Please review (and merge?) feature/better_power_off_button
Hi,

Please review the branch feature/better_power_off_button. It still has
some issues (one so serious that I didn't want to merge it into
experimental) and rough edges that I'll present below to hear your input
about, but once they're resolved I'd like to have it merged into devel
as a candidate for Tails 0.16.

It implements the solution described in the ticket
todo/better_power_off_button to the word. As a side-effect
todo/screen_locker was also implemented, using approach 1 described in
the ticket, i.e. "password-less amnesia user", so without a password set
in Tails Greeter "Lock Screen" just starts the screen saver.

Branch:  feature/better_power_off_button
Tickets: https://tails.boum.org/todo/better_power_off_button/
         https://tails.boum.org/todo/screen_locker/
Commits:
7e0de9c Make the default user password-less.
07c198a Make Shutdown Helper applet easier to test.
f7833c6 Add translation files for Shutdown Helper applet.
b37f657 Gettext:ize the Shutdown Helper applet.
f42f519 Replace emergency shutdown button with Shutdown Helper.
756970f Allow the amnesia user to reboot.
89cf221 Install gnome-screensaver.
8c7501b Add "Shutdown Helper" Gnome applet.



Issues and questions:

* Making the amnesia user password-less (i.e. `passwd -d amnesia`) seems
to override Tails Greeter. I can see TG flicker by when X starts, but it
proceeds to GNOME before I have the chance to interact with it. Any one
has any ideas? [This is the reason I didn't merge this branch into
experimental.]

* I have verified that translations work for the applet (i.e. its action
menu entries) but I don't know (I haven't even investigated) how to make
its bonobo server file translatable. That would make the strings shown
in the applet list (as seen via "Add to panel" for instance)
translatable. IMHO this isn't important and I'd rather not waste my
energy on it. What do you think?

* Since "Shutdown Immediately" is right below "Lock Screen" in the menu,
I assume users could miss-click it pretty easily. Perhaps making the
menu entries larger and/or putting separators between them could help
prevent that. Thoughts?

* The icon it currently uses for "Reboot Immediately" is "gtk-refresh"
:). It seems like the default GNOME theme doesn't have a dedicated icon
for reboot. We could use the same icon as for "Shutdown Immediately" but
I'd rather have something distinct. Any suggestions?

* Do we want to configure gnome-screensaver in some particular way?
Currently it starts the "Blank screen" screen saver after 5 minutes of
idling, without locking the screen.

Cheers!