Re: [Tails-dev] Please review and merge bugfix/gpgApplet_men…

Üzenet törlése

Válasz az üzenetre
Szerző: anonym
Dátum:  
Címzett: The Tails public development discussion list
Tárgy: Re: [Tails-dev] Please review and merge bugfix/gpgApplet_menu_in_bottom_panel
16/11/12 16:06, Ague Mill wrote:
> anonym:
>> Here's a small post-freeze bugfix for Tails 0.15 which fixes the
>> gpgApplet menu issue reported when using the Windows XP camouflage.
>>
>> Branch: bugfix/gpgApplet_menu_in_bottom_panel
>> Ticket: https://tails.boum.org/todo/fix_gpgApplet_with_Windows_camouflage/
>
>> diff --git a/config/chroot_local-includes/usr/local/bin/gpgApplet b/config/chroo
>> index 71932ec..f5d1568 100755
>> --- a/config/chroot_local-includes/usr/local/bin/gpgApplet
>> +++ b/config/chroot_local-includes/usr/local/bin/gpgApplet
>> @@ -161,7 +161,7 @@ b) the "Artistic License" which comes with Perl.
>>          my $time = shift;
>>          my ($x, $y, $push) = Gtk2::StatusIcon::position_menu($menu, $ticon);

>
> The change that follows makes this line useless, or did I miss anything?
>
>>          $menu->show_all;
>> -        $menu->popup(undef, undef, sub {($x, $y,$push)}, undef, $event, $time);
>> +        $menu->popup(undef, undef, undef, undef, $event, $time);
>>      });

>>
>>      $icon->signal_connect('button-press-event' => sub {


You're right. Fixed in commit:

51a0591 Remove now unused variables.

Cheers!