On Thu, Sep 27, 2012 at 11:24:04AM +0200, intrigeri wrote:
> Hi,
>
> Ague Mill wrote (26 Sep 2012 12:08:08 GMT) :
> > htpdate lists a "--proxy" option. I may assume that when I don't
> > specify this option, it will not use a proxy at all. But, the
> > current code will still use a proxy if HTTPS_PROXY or ALL_PROXY are
> > set. I think this is confusing.
>
> Fair enough, nice catch.
> Here's what I did, then:
>
> - [ 'proxy|p:s', "what to pass to curl's --socks5-hostname" ],
> + [ 'proxy|p:s', "what to pass to curl's --socks5-hostname (if unset, environment variables may affect curl's behavior -- see curl(1) for details)" ],
>
> >> > Uh... and actually, those changes might require to add some more
> >> > tests to the checklist. What do you think?
> >>
> >> I'll think of it later today or tomorrow.
>
> Done (19b552f) -- yeah, that's the bare minimum. I'm not sure if, and
> how, we would want to deeper dive into checking that Tor itself works
> as advertised.
>
> If the current state of this branch looks good enough, I suggest you
> build an ISO from devel + feature/separate_Tor_streams, and "run"
> these tests before merging.
Done the tests, works as expected, merged (with --no-ff this time) in
devel, and pushed.
I haven't updated the ticket, there was no qa tag in there, and I was not
really sure about the chenges that have to be done.
bert.
