On Mon, Sep 24, 2012 at 03:56:05PM +0200, bertagaz@??? wrote:
> > I'm not too happy with the initial commit (f00effb), because it
> > removes the check for the needed tool existence and leaves the exit
> > code checking to the implicit.
Fixed in devel.
> > I suggest:
> >
> > * re-adding something like:
> > [ -x /usr/sbin/ferm ] || exit 2
> >
> > * clarifying with a comment that the ferm command invocation should
> > remain the last one in this script.
I went with the `set -e` way instead of that last one.
> > About ferm.conf, the Emacs mode line sets shell-script, but given the
> > syntax, apparently conf-space-mode or perl-mode do a quite better job,
> > so I suggest:
> >
> > # -*- mode: conf[space] -*-
Done in devel.
--
Ague
