On Sat, Sep 22, 2012 at 07:04:25PM +0100, Alessandro Grassi wrote:
> attached patch should generate Iceweasel profile on build time, rather than
> run time. It is required for a "bookmarks" persistence preset (which I want
> to implement soon), as explained in the todo ticket:
>
> https://tails.boum.org/todo/persistence_preset_-_bookmarks/
>
> First time I send a patch, I hope it's ok :-)
Thank you for working on this! The patch in itself looks ok. :)
I know that you have future plans, but right now, what kind of benefits
would Tails get from generating an Iceweasel profile at build time?
Unless there is a clear answer to this question, I think it would be
better to wait until there is a complete patch set implementing
persistence for bookmarks.
How far have you tested this patch?
Does calling `iceweasel -CreateProfile` requires to have an X server
running?
Also, it would be better if the hook would start with `set -e` in order
to catch any errors that can happen in the process.
--
Ague
