Autore: anonym Data: To: The Tails public development discussion list Oggetto: Re: [Tails-dev] Please review some vagrant optimizations [was:
Shipping a 686-pae kernel]
11/09/12 22:21, alan@??? wrote: >
> Hi,
>
>>> Minor stuff regarding the changes:
>>>
>>>> commit fec1126adbf22213e8359729bec6d71fd390304c
>>>> +++ b/vagrant/provision/assets/build-tails
>>>> +TMPFS_SIZE_BYTES=$(echo "($TMPFS_SIZE_GB * 1024^3)/1" | bc) # rounded down
>>>
>>> I don't see the need for bc. How about dropping the floating point and
>>> having something like:
>>>
>>> TMPFS_SIZE_MB=6144 # 6 GB
>>> TMPFS_SIZE_BYTES=$(($TMPFS_SIZE_GB * 1024 * 1024))
>>
>> Err, you're absolutely right. I don't know what I was thinking. See
>> commit 12ba0ed.
>>
> I think this is wrong. The commit shows:
>
> -TMPFS_SIZE_GB=6.0
> -TMPFS_SIZE_BYTES=$(echo "($TMPFS_SIZE_GB * 1024^3)/1" | bc) # rounded down
> +TMPFS_SIZE_MB=6144 # 6 GB
> +TMPFS_SIZE_BYTES=$(($TMPFS_SIZE_GB * 1024 * 1024))
>
> If I'm not wrong, you changed TMPFS_SIZE_GB to TMPFS_SIZE_MB in the 1st
> line but not in the 2nd.
