Re: [Tails-dev] Please review some vagrant optimizations [wa…

Nachricht löschen

Nachricht beantworten
Autor: anonym
Datum:  
To: The Tails public development discussion list
Betreff: Re: [Tails-dev] Please review some vagrant optimizations [was: Shipping a 686-pae kernel]
10/09/12 20:13, Ague Mill wrote:
> On Mon, Sep 10, 2012 at 03:40:31PM +0200, anonym wrote:
>> Any one familiar with vagrant (ague?), please have a look and test this.
>> Once feature/vagrant is merged into devel, we can also revert commit
>> 974805d in feature/multikernel and instead merge in feature/vagrant.
>
> This is all very lovely. It's been a while since a wanted to add a way
> to cache the bootstrap stage.


:)

> Minor stuff regarding the changes:
>
>> commit fec1126adbf22213e8359729bec6d71fd390304c
>> +++ b/vagrant/provision/assets/build-tails
>> +TMPFS_SIZE_BYTES=$(echo "($TMPFS_SIZE_GB * 1024^3)/1" | bc) # rounded down
>
> I don't see the need for bc. How about dropping the floating point and
> having something like:
>
> TMPFS_SIZE_MB=6144 # 6 GB
> TMPFS_SIZE_BYTES=$(($TMPFS_SIZE_GB * 1024 * 1024))


Err, you're absolutely right. I don't know what I was thinking. See
commit 12ba0ed.

>> commit c34b0621706f1ae7ad25acb034bf010cae0fd7b5
>> +++ b/vagrant/provision/assets/build-tails
>> +       # cached yet?) so we we save the good one from the current build.
>                             ^^^^^
>                     once is probably enough


Commit 96a52c3.

> I've done some builds with or without using RAM. It seemed to work well.


Great! Feel free to merge now when everything seems sorted.

Cheers!