Re: [Tails-dev] Please review bugfix/fix_background_readahea…

Delete this message

Reply to this message
Author: Ague Mill
Date:  
To: The Tails public development discussion list
Subject: Re: [Tails-dev] Please review bugfix/fix_background_readahead
On Sun, Sep 02, 2012 at 02:37:24PM +0000, Ague Mill wrote:
> On Sun, Sep 02, 2012 at 03:28:36PM +0200, intrigeri wrote:
> > Ague Mill wrote (01 Sep 2012 12:26:51 GMT) :
> > > Can someone else test the changes, now? :)
> >
> > :)
> >
> > I'm unlikely to do it any time soon on bare metal,
> > but it might help it that work was merged into experimental.
>
> Given it's a candidate for 0.13, I think it's not the best branch to
> test it, but I've done the merge nonetheless.


I still understand what could it make worse than the current situation,
but given that:

  <anonym> I'd like to see that live in experimental for a while before
           I trust it :)
  <ague> Should I write another patch that remove the offending 'cat'
         that is not running in the background?
  <intrigeri> I think I would happily merge that one.


See attachment.

--
Ague
From 1c0883518de62c30b1aee8e40e706b39013806ec Mon Sep 17 00:00:00 2001
From: Tails developers <amnesia@???>
Date: Mon, 3 Sep 2012 17:44:09 +0000
Subject: [PATCH] Stop readahead pretending that it can read file in the background

Files are not read in the background. This means we have a noticable pause
without any progress bar. This just slow the boot process, so let's stop
reading those extra files.
---
 .../lib/live/config/0000-readahead                 |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)


diff --git a/config/chroot_local-includes/lib/live/config/0000-readahead b/config/chroot_local-includes/lib/live/config/0000-readahead
index c29edbd..fdaecf9 100755
--- a/config/chroot_local-includes/lib/live/config/0000-readahead
+++ b/config/chroot_local-includes/lib/live/config/0000-readahead
@@ -25,21 +25,15 @@ Readahead ()
 Start_readahead ()
 {
     FG_FILES="$(sed -n "\:$BACKGROUND_AT:q;p" "$READAHEAD_LIST")"
-    BG_FILES="$(sed -n "\:$BACKGROUND_AT:,\$p" "$READAHEAD_LIST")"
     FG_SIZE=$(
      cd /
      echo "$FG_FILES" |
      xargs du -c 2>/dev/null |
      awk '$2 ~ /^total$/ { t = t + $1 } END { print t }')
     (cd /
-     echo "$BG_FILES" |
-     xargs stat >/dev/null 2>/dev/null || :)
-    (cd /
      echo "$FG_FILES" |
      xargs cat 2>/dev/null |
      pv -f -s ${FG_SIZE}k >/dev/null || :)
-    (cd /
-     echo "$BG_FILES" | xargs cat >/dev/null 2>&1 || :) &


     # Creating state file
     touch /var/lib/live/config/readahead
-- 
1.7.2.5