Re: [Tails-dev] Include gdm logs in whisperback

Delete this message

Reply to this message
Author: alan
Date:  
To: tails-dev
Subject: Re: [Tails-dev] Include gdm logs in whisperback

> From: intrigeri <intrigeri@???>
> Date: Sat, 4 Aug 2012 18:13:37 +0200
>
> Hi,
>
> alan@??? wrote (29 Jul 2012 12:31:45 GMT) :
> > Implemented in tails git, branch feature/more_whisperback_logs,
> > merged into experimental. Please test !
>
> Great!
>
> I'll test it, but probably not before 10 days.
>

Thats not urgent!

> > +    except OSError:
> > +        debugging_info += "sudo command not found\n" % debug_command

>
> Why the "% debug_command"?
>

Well because I forgot to delete it...

> > +    except subprocess.CalledProcessError:
> > +        debugging_info += "debugging command returned an error\n" % debug_command

>
> The "% debug_command" lets me think a %s is missing in the
> format string, isn't it?
>

Same as above, old shit staying around. Corrected in git.

> > +debug_command() {
> > +    echo
> > +    echo "===== output of command $@ ====="
> > +    "$@"
> > +}

>
> I think this won't work once commands that span multiple words are
> used; or am I wrong, that is, do the changes introduced by commit
> 38293d actually work?


Well it seems me so (see the call to `dmidecode -s system-manufacturer`).


--