Hi,
Thanks for the review. See my answers inline bellow.
Ague Mill wrote (13 Jul 2012 17:42:23 GMT) :
> I don't really understand the choice of generating
> `/var/lib/gdm3/language_codes` in a live-build hook. Is there any
> reason why it can't be generated during tails-greeter build?
> It could then be shipped in a more policy compliant place than
> `/var/lib` (it is static data, after all, and only consumed by
> tails-greeter AFAIU).
Done in updated branches: tails-greeter now ships
/usr/share/tails-greeter/language_codes. Untested yet.
If it looks good to you, I'll squash the branch and test it before
someone merges it into devel.
> Have you made any tests?
I did test the code you reviewed.
> Did you notice a decrease in login time?
Not on my test VM, but I expect dropping localedef to save a few
seconds on slower boxes.
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
