Hi,
Ague Mill wrote (02 Jun 2012 12:13:12 GMT) :
> I have implemented most of what I was suggesting in the
> `feature/shutdown_cleanup` branch. This branch is not meant for 0.12
> and will probably be rebased. I welcome comments on the approach but
> I do want to more tests before a formal merge request.
Great work. Comments follow.
> We now use this mechanism instead of having to call update-rc.d
> manually, something quite error prone. Best example is that
> 'ttdnsd' is actually requiring to be started after 'tor', but
> that fact was previously overlooked.
I obviously agree with the general idea, but FTR I think this example
is plain wrong: this was not overlooked (see the 60-ttdnsd.sh NM
dispatcher hook).
> +++ b/config/chroot_local-includes/etc/insserv/overrides/gdomap
> @@ -0,0 +1,11 @@
> +### BEGIN INIT INFO
> +# Provides: gdomap
> +# Required-Start: $remote_fs $syslog
> +# Required-Stop: $remote_fs $syslog
> +# Default-Start:
> +# Default-Stop: 0 1 6 2 3 4 5
> +# Short-Description: Start the GNUstep distributed object mapper
> +### END INIT INFO
Do we really need to duplicate that much of the header,
instead of just overriding the field we want to change?
If insserv forces us to do so: I agree such overrides are better than
manually patching initscripts or using update-rc.d when we previously
did so, but for other cases (I mean, initscripts we did not hack in
any way previously), I seriously doubt the added maintenance cost is
worth a quicker non-emergency shutdown.
> Tails shutdown sequence should be as fast as possible.
This is probably nitpicking, but such an unbacked assertion means
little to me, especially since we already have a totally separate
emergency shutdown procedure.
Apart of the information duplication issue, all this looks pretty
good -- congrats!
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
