Re: [Tails-dev] memlockd stopped too soon

Poista viesti

Vastaa
Lähettäjä: intrigeri
Päiväys:  
Vastaanottaja: The Tails public development discussion list
Aihe: Re: [Tails-dev] memlockd stopped too soon
hi,

Ague Mill wrote (01 Jun 2012 14:38:06 GMT) :
> Please have a look at the `bugfix/dont_stop_memlockd` branch. It is
> a candidate for 0.12.


Looks great!

A few minor comments, that may be related, and may be not, you tell
me:

* The commit message reads "In addition, we fix initscript ordering
related to tails-sdmem-on-media-removal." -- why and how?
* Why are the tails-reconfigure-kexec and tails-reconfigure-memlockd
initscripts moved to by-hand numbering?
* It's not clear why the tails-sdmem-on-media-removal start order
changes. Both, given nothing in the commit message talks of
initscripts startup.

To end with, I think the explanations found in the commit message
would be worth pushing to the memory wipe design doc. I think this is
the kind of knowledge we really don't want to have to dig in the Git
history when we need it.

> +       rm -f /lib/init/rw/sendsigs.omit.d/memlockd
> +       ln -s /var/run/memlockd.pid /lib/init/rw/sendsigs.omit.d/memlockd


Why not using "ln -sf" instead?