Re: [Tails-dev] next big features: status update

Delete this message

Reply to this message
Author: intrigeri
Date:  
To: The Tails public development discussion list
Subject: Re: [Tails-dev] next big features: status update
sajolida wrote (20 Mar 2012 17:40:59 GMT) :
> Cool. Could something like this do the trick? There's one patch for
> Tails greeter and another for the feature/tails-greeter branch.
> I didn't test it though, and wanted your opinion first.


>  # Check if password is actually set
>  if [ -z "${TAILS_USER_PASSWORD}" ] ; then
> -    rm -f "${POLKIT}" "${SUDOERS}"
> +    rm -f "${POLKIT}" "${SUDOERS}" "${CUSTOM_LECTURE}"
> +
>      deluser "${LIVE_USERNAME}" sudo
>      log_n_exit "Password variable not found."
>  fi


It seems to me the logics is backwards here:
the custom lecture should be displayed iff. no password is set,
rather than hidden iff. no password is set,
isn't it?

Otherwise, looks good!

cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
| The impossible just takes a bit longer.