Re: [Tails-dev] [gsoc] tails-greeter progress report

Delete this message

Reply to this message
Autor: intrigeri
Data:  
Para: The Tails public development discussion list
Assunto: Re: [Tails-dev] [gsoc] tails-greeter progress report
Hi,

here are some more comments, in addition to the bunch of private email
I've already sent you.

If tails-lang-helper and tails-locale-gen are for internal use only,
which seems to be the case, they probably should be installed to
/usr/share/ rather than /usr/bin/.

Any reason to have the .desktop file weirdly named
a-tails-greeter.desktop? IIRC this was an old attempt to have it run
before gdm-simple-greeter, that you disable using dpkg-divert
nowadays.

python-support is now deprecated¹. The Debian packaging will need to
be converted at some point; see dh_python2(1) for details.
Low-priority, though.

¹ http://lists.debian.org/debian-python/2011/06/msg00136.html

Current Git code crashes at runtime since you renamed the helper
scripts without updating the code that run them. Once I've (trivially)
fixed autologin.py and language.py in my local Git repo, your current
Git branch (at 82c1d0e9) is still crashing:

  [DEBUG] language.py:36 <module>: 144 languages found: helper returned 0
  Traceback (most recent call last):
    File "./community-greeter.py", line 44, in <module>
      from GdmGreeter.language import Translatable
    File "/usr/lib/pymodules/python2.6/GdmGreeter/language.py", line 37, in <module>
      LANGS = map(lambda x: babel.Locale.parse(x), langcodes)
    File "/usr/lib/pymodules/python2.6/GdmGreeter/language.py", line 37, in <lambda>
      LANGS = map(lambda x: babel.Locale.parse(x), langcodes)
    File "/usr/lib/pymodules/python2.6/babel/core.py", line 212, in parse
      return cls(*parse_locale(identifier, sep=sep))
    File "/usr/lib/pymodules/python2.6/babel/core.py", line 137, in __init__
      raise UnknownLocaleError(identifier)
  babel.core.UnknownLocaleError: unknown locale 'an'


So I cannot test much further. Hence the need to have tagged
known-working, "please test this one" snapshot pre-releases. Reverting
82c1d0e9 makes the whole thing working, but only proposes the English
language due to the issue 82c1d0e9 was trying to fix.

Please set debian/source/format to "3.0 (native)" (lintian
missing-debian-source-format info message).

You probably have noticed it already, but just in case: your lintian
overrides don't work at all, presumably because you applied them to
the source package while lintian is concerned with the binary package.
By the way, the following set of lintian options will be of great help
for learning: --info --display-info --pedantic --show-overrides

Bye,
--
intrigeri <intrigeri@???>
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
| Then we'll come from the shadows.