Package: vidalia
Version: 0.2.10-3
Severity: normal
Tags: patch
Hi,
vidalia.config script contains wrong logic I think: it kills the
system-wide Tor daemon if vidalia/tor-daemon-interaction is set to
"nothing" or "one-off". According to the debconf templates, "nothing"
means:
* No configuration:
leave Tor running for now. Vidalia will not be able to
communicate with Tor until it is manually reconfigured - see
"/usr/share/doc/vidalia/README.Debian" for more details;
In that case, I don't think Vidalia's config script should interfere
in any way with the system-wide Tor daemon.
On the other hand, when this debconf parameter has the "permanent"
value, I think Vidalia's config script should stop it as documented:
* Permanent takeover:
stop Tor and simply let Vidalia handle starting it whenever you
run Vidalia (not usable on a multi-user system).
The attached Git patch (against current packaging repository master
branch) fixes this, I think.
I'm only setting severity "normal", but this bug may deserve a higher
severity as it interferes with (and even kills) another package's bits
while asked not to do so.
-- System Information:
Debian Release: 6.0.1
APT prefers stable-updates
APT policy: (990, 'stable-updates'), (990, 'stable'), (2, 'testing'), (1, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages vidalia depends on:
ii debconf [debconf-2.0] 1.5.36.1 Debian configuration management sy
ii libc6 2.11.2-10 Embedded GNU C Library: Shared lib
ii libgcc1 1:4.4.5-8 GCC support library
ii libqt4-network 4:4.6.3-4 Qt 4 network module
ii libqt4-xml 4:4.6.3-4 Qt 4 XML module
ii libqtcore4 4:4.6.3-4 Qt 4 core module
ii libqtgui4 4:4.6.3-4 Qt 4 GUI module
ii libssl0.9.8 0.9.8o-4squeeze1 SSL shared libraries
ii libstdc++6 4.4.5-8 The GNU Standard C++ Library v3
ii ucf 3.0025+nmu1 Update Configuration File: preserv
Versions of packages vidalia recommends:
ii tor 0.2.1.30-1 anonymizing overlay network for TC
Versions of packages vidalia suggests:
ii xul-ext-torbutton [iceweasel- 1.2.5-3 Iceweasel/Firefox extension enabli
-- debconf information:
* vidalia/info: no
* vidalia/tor-daemon-interaction: nothing
>From 3456f80933cb3ec771f9a4c87df7bf24883bc1a6 Mon Sep 17 00:00:00 2001
From: intrigeri <intrigeri@???>
Date: Mon, 18 Apr 2011 12:29:52 +0200
Subject: [PATCH] Fix system-wide Tor daemon handling to match documented behaviour.
---
debian/0.2.x/config | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/debian/0.2.x/config b/debian/0.2.x/config
index dc061e5..10b4d44 100644
--- a/debian/0.2.x/config
+++ b/debian/0.2.x/config
@@ -44,7 +44,7 @@ if [ "$1" = "configure" ] || [ "$1" = "reconfigure" ]; then
# still running?? (e.g. chroot)
if [ "$seen" = "false" ]; then
askuser
- if [ "$RET" = "nothing" ] || [ "$RET" = "one-off" ]; then
+ if [ "$RET" = "permanent" ] || [ "$RET" = "one-off" ]; then
echo -n "Stopping tor daemon: "
pkill -x tor > /dev/null && echo "tor." || echo 'Failed!'
fi
--
1.7.2.5
