Hi,
27/09/14 12:53, Kill Your TV wrote:
> On Fri, 26 Sep 2014 16:25:14 +0000 (UTC)
> anonym <anonym@???> wrote:
>
>
>> First of all, great work! It works really good, and works pretty
>> nicely as-is. I have some doubts about it making it into Tails 1.2,
>> which I attribute to me being so late with reviewing. I could
>> consider merging it with if you commit strongly to be available to
>> fix things post-freeze. What do you think? IMHO you should prioritize
>> getting feature/7732-i2p-network-manager-hook ready for merge, though.
>
> Assuming I'm not hit by a bus in the meantime, I'll be around for
> fixing up things post-freeze.
Great!
>> Now for some commit-specific remarks:
>>
>>> commit 79f87a1b Hide bookmark/history
>>
>> Interesting. See https://labs.riseup.net/code/issues/7948 . Maybe what
>> you suggest is actually better, since the start page is the router
>> console and as a portal it definitely beats a lousy bookmarks folder.
>> Actually the (unstated) rationale for #7948 was mostly to have the
>> router console easily available.
>
> I did what made the most sense to me at the time but I am open to
> changes, ofc. :)
Your way is much nicer so let's leave it.
Oh, and regarding commit d45c28e, the I2P bookmarks should be completely
removed from the Tor Browser (completely removed, in other words).
>>> commit 2b0fe4a hide "get addons" in addon-manager
>>
>> Also interesting. This should be back-ported into the Unsafe Browser
>> too, imho. Well, the correct thing to do would be to make a shell
>> library to make task-specific chroot browsers, but that's a post-1.2
>> goal.
>>
>> Can it be taken to the next level, i.e. disabling altering the add-ons
>> completely?
>
> It's likely doable but I don't know how at the moment. If it's doable I
> can almost certainly figure it out for 1.2.1 or 1.3.
Filed as:
https://labs.riseup.net/code/issues/7970 and optimistically
assigned to you.
>>> commit d264cc9 Switch I2P-Browser from Iceweasel to Tor-Browser
>>
>> Why not installing Torbutton too, and configuring it to use I2P
>> instead? I imagine the protections it adds also make sense for I2P?
>> If so, this is a regression (in terms of "security") from the
>> FoxyProxy-way of doing this.
Torbutton is shown with a red X on it, which looks scary. I wonder if
the misconfiguration causing it puts Torbutton in a state in which some
important defence/feature is disabled, or if it's just an indication of
misconfiguration. Any way, we don't want to show the button at all
because the "New feature" thing won't work and hence will be misleading.
If you set `extensions.torbutton.inserted_button = true` it will be hidden.
So, I suggest the following patch, which I verified works; it both makes
configures Torbutton so that it doesn't show the X, *and* it removes the
button... pedantic, perhaps, but at least we don't have to worry about
the the question about Torbutton disabling features in the "red X"
stateu. :)
---
/lib/live/mount/rootfs/filesystem.squashfs/usr/local/sbin/i2p-browser
2014-09-29 00:51:51.000000000 +0000
+++ /usr/local/sbin/i2p-browser 2014-09-29 02:09:13.678449711 +0000
@@ -182,13 +182,14 @@
${BROWSER_PREFS}
# add the I2P proxy to all protocols
cat > "${BROWSER_PREF_DIR}/i2p.js" << EOF
-user_pref("network.proxy.http", "127.0.0.1");
-user_pref("network.proxy.http_port", 4444);
-user_pref("network.proxy.ftp", "127.0.0.1");
-user_pref("network.proxy.ftp_port", 4444);
-user_pref("network.proxy.ssl", "127.0.0.1");
-user_pref("network.proxy.ssl_port", 4444);
-user_pref("network.proxy.share_proxy_settings", true);
+user_pref("extensions.torbutton.inserted_button", true);
+user_pref("extensions.torbutton.settings_method", "custom");
+user_pref("extensions.torbutton.custom.http_proxy", "127.0.0.1");
+user_pref("extensions.torbutton.custom.http_port", 4444);
+user_pref("extensions.torbutton.custom.https_proxy", "127.0.0.1");
+user_pref("extensions.torbutton.custom.https_port", 4444);
+user_pref("extensions.torbutton.custom.ftp_proxy", "127.0.0.1");
+user_pref("extensions.torbutton.custom.ftp_port", 4444);
user_pref("network.proxy.no_proxies_on", "127.0.0.1");
EOF
# Hide options in the I2P Browser.
> I think the changes requested have been addressed. Please see the
> latest pushed commits.
After these things are fixed, and the user documentation has been
upgraded at `wiki/src/doc/anonymous_internet/i2p.mdwn`, I believe it's
ready to be merged.
Again, great work!
Cheers!
