Re: [Tails-dev] Please review'n'merge feature/ff24

Delete this message

Reply to this message
Autor: Alan
Data:  
Dla: tails-dev
Temat: Re: [Tails-dev] Please review'n'merge feature/ff24
Hi,

On Fri, 22 Nov 2013 20:58:20 +0100 intrigeri <intrigeri@???> wrote:
> => please review'n'merge, for real, this time, hopefully.
>

Code review
===========

- I'm not convinced by the folowing change
in config/chroot_apt/preferences

+Package: *
+Pin: origin mozilla.debian.net
+Pin-Priority: 990

If I'm not mistaken, that would pull any package from
mozilla.debian.net. If a package appears there for whatever reason,
it is likely to break the feature in subtle ways. Why not list the
specific packages we want, as we did before?

- wiki/src/contribute/design/stream_isolation.mdwn: please document why
the port number doesn't follow the other's logic:

+* dedicated `SocksPort` for web browser (9151): no stream
+ isolation options

- you forgot to push 496ad87 to the feature branch.

Otherwise I'm happy with it.

APT
===

OK

Tests
=====

> does the exposed User-Agent match the TBB's one? (connect to a website
> you can check the access logs for)


OK

> Running getTorbuttonUserAgent should produce the useragent set by the
> Torbutton version installed and used in Iceweasel.


Please give me a hint how to run that.

> Browsing (by IP) a HTTP or HTTPS server on the LAN should
> be possible.


OK

> Browsing (by IP) a FTP server on the LAN should be
> possible.


OK

> Does playing HTML5 videos work? In particular, (due to its
> popularity) do youtube videos work (once easier YouTube is fixed --
> currently object unblocking in NoScript is required)?


Yes

> Compare the fingerprint of Tails and the latest TBB using at least
> https://panopticlick.eff.org/ and http://ip-check.info/, and update
> the fingerprint section of the known issues page.


Corresponds to known issues.

Torbrowser still works.

Basic web browsing works.

My conculsion
=============

Amazing job!

Please push your branch, and answer the APT preferences question before
I merge.

Cheesr