Re: [Tails-dev] Please review & merge bugfix/udisks-do-not-…

Borrar esta mensaxe

Responder a esta mensaxe
Autor: bertagaz
Data:  
Para: The Tails public development discussion list
Asunto: Re: [Tails-dev] Please review & merge bugfix/udisks-do-not-make-Tails-USB-unbootable
Hi,

On Sat, Mar 23, 2013 at 07:26:14PM +0100, intrigeri wrote:
> Hi,
>
> Ticket: todo/palimpsest:_do_not_make_Tails_USB_unbootable
> (updated and tagged todo/qa locally, can't push right now as the
> live website is locked / being rebuilt).
>
> Merged into experimental, candidate for 0.17.2 and 0.18
> => please review & merge into stable and devel.
>
> [...]
>
> All this was implemented in
> bugfix/udisks-do-not-make-Tails-USB-unbootable. It works for me:
>
>   * I still can install Tails on USB, boot from USB, setup
>     persistence, reboot, delete persistent volume, reboot. One can
>     check with sgdisk that the bootable flag is still here.
>   * I now can install Tails on USB, boot from USB, create a partition
>     with GNOME Disk Utility, reboot.

>
> Note that even with the parted bugfix in place, only the bootable flag
> is preserved, not the 3 non-critical other ones we set, but I consider
> they're merely bonus, so I'm ignoring this for now (and actually,
> I doubt we can ever do better without patching parted, which does not
> seem worth it, so I'm not even filing a ticket about it).
>
> Most of the changes are in the APT repository, t-p-s Git repo and
> liveusb-creator repo, so reviewers should inspect these in addition to
> the minor commit in our main Git repo.


Tested, works as explained, so :

- Cherry-picked commit f1ccd742 back from experimental, as it wasn't in
the bugfix/udisks-do-not-make-Tails-USB-unbootable branch.
- Merged into stable and devel, in git and the apt repo
- Updated the ticket to pending.

Hope I didn't miss something.

bert.