Re: [Tails-dev] [gsoc] tails-greeter progress report

Nachricht löschen

Nachricht beantworten
Autor: intrigeri
Datum:  
To: The Tails public development discussion list
Betreff: Re: [Tails-dev] [gsoc] tails-greeter progress report
Hi,

† wrote (24 Jun 2011 14:40:24 GMT) :
> 24.06.2011 12:34, intrigeri пишет:


>> My pylint reports no error. Beware not letting the pile of warnings
>> grow bigger and bigger, else it will prove difficult to sort these out
>> once the code is bigger, working and lacking a testsuite.


> Indeed, no more errors. I've corrected wiki entry. The thing about
> warnings is that many of them are related to the parts of code which
> we do not use or even do not plan to use so there is not my point in
> correcting them right now. I'll try to fix them gradually although I
> guess it's rather low-priority task atm


Then kill the unneeded code, and worry about the bits you don't use
yet as incrementally, as soon as you start using (and probably
adapting) it. Added benefit: it's a nice way to get to know the code
you're re-using.

> and I'll try to keep the warnings to the minimum in new code.


Great.

>> I didn't get it working. Seems like it depends on some kind of
>> USER_CONFIG (USER_CONFIG = '/home/users/%s.user') configuration
>> file, whose exact path and content isn't documented on
>> TailsGreeter/install; when I click one of the languages button,
>> nothing interesting happens and :0-greeter.log displays:


> Ahh, great that you've found it, thanks! Should be fixed with latest
> git push.


Indeed, it's fixed.

Now you probably want to refresh the existing .po files that lack the
strings you've introduced, generate some new .po files for the
languages you current UI supports, put some dummy translations in
there so that we can make sure the language buttons actually have the
intended effect.

>> Please explain in the design doc what current limitation requires the
>> supported languages list (I guess this is what you mean by "locales")
>> to be known at build time. Please also sum up what possible solutions
>> you've thought of along with their pros and cons.


> I've updated design page. Should be clearer now.


Indeed it's clearer. IMHO, using different sets of available languages
in tails-greeter and in the Tails GNOME session itself would be
greatly confusing for users, and probably complicate the code
needlessly. Both should IMHO at least minimally support every language
supported e.g. by the Debian installer (or GNOME). I wonder why would
we want to make these sets different the way you wrote on the design
page. Any rationale I missed?

>> I don't think so, see above. You indeed updated this early in the
>> week, but the testing instructions must be *kept* up-to-date.


> Updated install instructions recently.


Thanks. Please clarify "disable default greeter by editing
/usr/share/gdm/autostart/LoginWindow/gdm-simple-greeter.desktop"
there.

>> Great idea. Have you already tried reaching the developer(s)?


> Yes, although it happened more "early morning" than "late night" due
> to time difference :) As a result login is working now although not
> via BeginAutoLogin feature but through "regular" user-auth procedure
> (hardcoded user & password). I've tested BeginAutoLogin and it works
> too so probably I'll use it in near future.


I couldn't make the login work.
Are you sure this should work in the code you've published?

Click "Forward" => black screen, blinking text-mode cursor.
End of the log is:

The application 'polkit-gnome-authentication-agent-1' lost its
connection to the display :0.0; most likely the X server was shut
down or you killed/destroyed the application.

The application 'community-greeter.py' lost its connection to the
display :0.0; most likely the X server was shut down or you
killed/destroyed the application.

> Anyway, I have a question on "add .deb to tails repo" - how to do
> it? Do we integrate source package?


Just drop the .deb i386 binary package into
config/chroot_local-packages/. No need to add the source package as
long as the binary package has enough information in it (repository
location + proper versionning + Git commit id) so that anyone can have
access to the source and reproduce the build.

> I've also added note about dpkg-divert - I'll take a look how to
> integrate it into .deb: now when we have working logon procedure it
> actually make sense to do earlier :)


Right. I think I've emailed you some pointers to other packages that
use dpkg-divert already, so digging into your INBOX should provide
enough guidance to get you started.

Bye,
--
intrigeri <intrigeri@???>
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
| Then we'll come from the shadows.